[TYPO3-english] PATH_thisScript definition cleanup

[Simon Strandgaard]

One of the first pieces of code in typo3_src/index.php is used
(inconsistently) several other places in the typo3 codebase.

define('PATH_thisScript',str_replace('//','/', str_replace('\\','/',
(PHP_SAPI=='cgi'||PHP_SAPI=='isapi'
||PHP_SAPI=='cgi-fcgi')&&($_SERVER['ORIG_PATH_TRANSLATED']?$_SERVER['ORIG_PATH_TRANSLATED']:$_SERVER['PATH_TRANSLATED'])?
($_SERVER['ORIG_PATH_TRANSLATED']?$_SERVER['ORIG_PATH_TRANSLATED']:$_SERVER['PATH_TRANSLATED']):($_SERVER['ORIG_SCRIPT_FILENAME']?$_SERVER['ORIG_SCRIPT_FILENAME']:$_SERVER['SCRIPT_FILENAME']))));


I think I had to use isset() in some ajax code for it to work, like this.

define('PATH_thisScript',str_replace('//','/', str_replace('\\','/',
(PHP_SAPI=='cgi'||PHP_SAPI=='isapi'
||PHP_SAPI=='cgi-fcgi')&&(isset($_SERVER['ORIG_PATH_TRANSLATED'])?$_SERVER['ORIG_PATH_TRANSLATED']:$_SERVER['PATH_TRANSLATED'])?
(isset($_SERVER['ORIG_PATH_TRANSLATED'])?$_SERVER['ORIG_PATH_TRANSLATED']:$_SERVER['PATH_TRANSLATED']):(isset($_SERVER['ORIG_SCRIPT_FILENAME'])?$_SERVER['ORIG_SCRIPT_FILENAME']:$_SERVER['SCRIPT_FILENAME']))));


It solved a nasty php error that I had
PHP Notice: Undefined index:  ORIG_SCRIPT_FILENAME in
/some/long/path/file.php on line 1234,
referer: http://example.com/index.php?id=4321


Would this be an improvement to typo3?


-- 
Best regards
Simon Strandgaard