[Typo3] Gremlin: GIFBUILDER 256 color patch

[JoH]

> The result is much better than before. No artefacts in
> background-images around the letters anymore.
>
> Have a look at this page http://nenni-art.4any1.de while keeping in
> mind that all "transparency" inside or around letters is in fact a
> cropped 24bit background image with some GIFBUILDER text rendered
> over it.
> BTW: Don't complain about the design - that has not been our job!
>
>
> Good job! And thanks for sharing, Bernhard!

After klicking around for a while I noticed another small bug that occurs
once in a while.

Warning: unlink(typo3temp/temp/760f5d9aee59c8a111a2f35e2a95085d.miff): No
such file or directory in
/home/cmsbox/4any1.de/typo3conf/ext/kb_allcolors/class.ux_t3lib_stdgraphic.p
hp on line 2816
Warning: Cannot modify header information - headers already sent by (output
started at
/home/cmsbox/4any1.de/typo3conf/ext/kb_allcolors/class.ux_t3lib_stdgraphic.p
hp:2816) in /home/typo3_src-3.8.0/typo3/sysext/cms/tslib/class.tslib_fe.php
on line 2612

After looking into the code I found out that it has something to do with the
following command

unlink($postName)

After inserting a flag into the while loop and checking the flag before
unlinking the file it seems to work:

function unifyColors(&$img, $colArr) {
...
   while(list(,$transparentColor)=each($colArr)) {
    $transparentColor = $this->convertColor($transparentColor);
    $transparentColor = $this->hexColor($transparentColor);
    $cmd = '-fill "'.$firstCol.'" -opaque "'.$transparentColor.'"';
    $this->imageMagickExec($preName, $postName, $cmd);
    $preName = $postName;
    $postNameExists = 1;
   }
...
    // unlink files from process
   if (!$this->dontUnlinkTempFiles) {
    unlink($origName);
    if ($postNameExists) {
     unlink($postName);
    }
   }
  }
  return $retCol;
 }


-- 
Wenn man keine Ahnung hat: Einfach mal Fresse halten!
(If you have no clues: simply shut your knob sometimes!)
Dieter Nuhr, German comedian
openBC: http://www.openbc.com/go/invuid/Jo_Hasenau