[TYPO3-dev] Feedback for #13698 - Add proxy for the mail() function

[Tolleiv Nietsch]

Hi,
since it's not very nice to bug users with mails from development 
systems and since it's also not very handy to search&replace all mail 
adresses within a dump which came back from a live system I though that 
adding a hookable proxy to all mail() calls would be a good idea.

The related patch can be seen on 
http://bugs.typo3.org/view.php?id=13698. I didn't post into the Core 
list so far because I wanted to prepare some kind of dummy extension 
which makes use of the provided hook - just to make testing easier.

A few days ago Benny responded and asked to change the patch and pointed 
me to t3lib_div::plainMailEncoded() which should act as proxy instead.

After a more detailed view I can't really agree to his opinion to use 
plainMailEncoded() as proxy for t3lib_htmlmail without a huge amount of 
refactoring, since t3lib_htmlmail fully defines all mail headers on his 
own and sends out multipart (plain + html) mails whereas 
plainMailEncoded() assumes that the mail is "just" a plaintext mail and 
nothing else.

Before starting to refactor t3lib_htmlmail I wanted to bring that up and 
ask for some feedback. So either

a) have a proxy function on his own which is used by t3lib_htmlmail and 
plainMailEncoded
b) refactor t3lib_htmlmail to use plainMailEncoded

Besides that - the other occurences of mail() (outside of t3lib_htmlmail 
and t3lib_div::plainMailEncoded()) should imho be replaced anyways ( 
http://bugs.typo3.org/view.php?id=13774 )

Cheers,
Tolleiv
-- 
Tolleiv Nietsch
www.tolleiv.de - www.aoemedia.de
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sendMail_v2.patch
URL: <http://lists.typo3.org/pipermail/typo3-dev/attachments/20100308/e2103e6d/attachment.txt>