[TYPO3-dev] includeCSS and htmlspecialchars: bug?

[bernd wilke]

I just tried to use a variable CSS-file.

therefore I took this TYPOSCRIPT:


page {
	includeCSS {
		varcss = fileadmin/css/csscalc.php?col1=ff0000&col2=0000ff
		// neccessary for include without check for existence:
		varcss.external = 1	
		:
	}
	:
}

the resulting HTML was:
<link rel="stylesheet" type="text/css" href="fileadmin/css/csscalc.php?
col1=ff0000&amp;col2=0000ff" media="screen" />

which leads with a print_r($_GET) to this:

GET=Array
(
    [col1] => ff0000
    [amp;col2] => 0000ff
)
 
looking in the source of V4.3.2 I found in class.tslib_pagegen.php at 
line 546 the functioncall  htmlspecialchars() which changes the '&' into 
'&amp;'

I think this should not be called. at least if external is true.

As I'm not able to provide a patch maybe someone else could do it 
changing the line to
$GLOBALS['TSFE']->pSetup['includeCSS.'][$key . '.']['external'] ? $ss : 
htmlspecialchars($ss) ,

bernd
-- 
http://www.pi-phi.de/cheatsheet.html