[TYPO3-dev] TCEforms suggest fails on large sites

[Steffen Gebert]

Hi,

TCEforms is a really nice feature and I had some tests today.

Unfortunately it has hardcoded limits, which are too low for one of our  
sites (>20.000 pages).

We have ~450 pages called "Links" or "Home" (each user has this page in  
his default site).

So depending on how old/new a user is, these pages are found or not.

Because:
* queryTable() gets 50 (hardcoded) results from DB (every page in result  
is called "Links")
* checkRecordAccess sorts all/most of them out
* count($rows) < $this->maxItems && $allRowsCount >= 50 &&  
$recursionCounter < $this->maxItems
   matches ($this->maxItems = 10)
* ++$recursionCounter and recursive call to get more results (start again)

So there is a maximum of 10 recursions (as recursionCounter < maxItems),  
which I don't understand (has nothing to do with each other) and also  
limits to (theretically) 500 examined records.

I don't know why, but the query doesn't find as much as expected: If I  
increase maxItems to 50, pages are also not found. If I encrease to 200,  
the maximum nesting level of 100 gets reached.

Wouldn't it make sense, to check as a limit for $allRowsCount > 50 *  
$this->maxItems ? Nevertheless, this might also lead to reach maximum  
nesting level :(

Only way to get it, was to change hardcoded LIMIT of 50 to way higher  
values.

Hope you catch my thoughts.. it might sound a bit oversized to speak of  
500 pages with the same name having only access to one of them.. but how  
should I tell newer users that this great feature might not always work  
for them :(

Hope you have ideas...

Regards
Steffen