[TYPO3-dev] tiny improvment for includeCSS / JS

Steffen Kamper steffen at sk-typo3.de
Sun Sep 30 23:47:25 CEST 2007


"Christian Wolff" <Chris at connye.com> schrieb im Newsbeitrag 
news:mailman.1.1191188144.12273.typo3-dev at lists.netfielders.de...


>>>
>>> page.includeCSS.file1 = style.css
>>> page.includeCSS.file1.condition = foo
>>>
>>> rendered as:
>>>
>>> <!--[if foo]><link rel="stylesheet" type="text/css" href="style.css"
>>> />![endif]-->
>>>

its a great idea +1
but i think the option name could be clearer to make clear its meand for
contional comment.

maybe we Could solve this problem
page.includeCSS.file1 = style.css
page.includeCSS.file1.conditionalCommentWrap = <!--[if foo]>|![endif]-->

so you cann use downlevel-hidden (<!--[if expression]> HTML <![endif]-->)
and downlevel-revealed (<![if expression]> HTML <![endif]>) conditional
Comments.

maybe we should simply ad a stdWrap feature. so it can be done wis the
normal
.stdWrap.wrap = <!--[if foo]>|![endif]-->

greets chris


i don't see that stdWrap is really needed here because wrap is the only 
senseful option for this.
condition is ok IMHO as it is
1) easy for the user (think of the condition syntax, type error could be 
done)
2) easy to understand in this context, may be better to name it 
browserCondition

I will do a patch for this option, i will post the Link after.

vg  Steffen

-- 
Christian Wolff // Berlin
http://www.connye.com

Latest Projects:
http://www.flycall.de | http://www.atr24.de | http://www.titanic.de 






More information about the TYPO3-dev mailing list