[TYPO3-dev] [TYPO3-Dev] Please do rearrange the source of class.tslib_content.php

[Dennis Cheung]

Hi Dmiry,

Sorry, I cannot found which section mentiond the statement style from
the document,
http://typo3.org/documentation/document-library/core-documentation/doc_core_cgl/current/view/
>From the "Line Formatting" section, it is likely to be a K&R format.

Their jobs are important, that's why we need to rearrange the source code.
It is easily to get bugs when your code not readable. Readability is
very important, many books from masters say that.

Ofcouse, I can do format on my local copy. It is easy, just press a
button in phpeclipse.
But after I did that, I cannot report bugs with line numbers. It will
be hard to apply patch.

Dennis


On 2/23/06, Dmitry Dulepov <typo3 at fm-world.ru> wrote:
> Hi!
>
> Dennis Cheung wrote:
> > I have noticed that the file class.tslib_content.php is too larger and
> > the code do not have common coding style.
>
> Historical reasons...
>
> > The code inside the file do not apply BSD/GNU/K&R style.
> > sometimes it wrote IF statement in a single line, and sometimes it use
> > K&R style.
> > It is very difficult to read.
>
> Well, there is a typo3 coding guidelines, so BSD/GNU/K&R style is not
> directly applicable. I think coding there reflects long evolution of
> this file...
>
> Anyway, core developers have more than enough job to do. If you think it
> is important to change coding style, you can do it yourself. I think
> core developers have more important things to change than readability of
> this particular file ;)
>
> Dmitry.
> --
> "It is our choices, that show what we truly are,
> far more than our abilities." (A.P.W.B.D.)
> _______________________________________________
> TYPO3-dev mailing list
> TYPO3-dev at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev
>