[Typo3-dev] charset

[Ivan Abramov]

Hi

I have installed the gsi_mailform_ext.

I tested mailform with russian charset  windows-1251

in HTML mode I received wrong message.

the headers not good (look how the spam filter reacts), listing in the
end of my message

charset=iso-8859-1, not  windows-1251

after this, I checked the code and found no replacement of code that works
with charset

in original  class.ux_t3lib_htmlmail.php there are few places where charset
is hardcoded, for sample:

function useBase64() {

$this->plain_text_header = 'Content-Type: text/plain;
charset=iso-8859-1'.chr(10).'Content-Transfer-Encoding: base64';

$this->html_text_header = 'Content-Type: text/html;
charset=iso-8859-1'.chr(10).'Content-Transfer-Encoding: base64';

$this->alt_base64=1;

}

and so on.... in t3lib_div, t3lib_formmail...

Tell me if I missed something.

After analyze of core code I have the conclusion what there are 2 ways.

1. fix existent code, wich has so many bugs
2. completelly rewrite it, use some tested api like phpMailer.

I want to understand wich way is preferable to typo3.

all users with language differ then iso-8859-1 have troubles with mails I
thing.

I'am preparing patch & ext.

Best wishes
Ivan



Return-Path: <tester at localhost.com>
X-Envelope-To: tester at localhost.com
X-Spam-Status: Yes, hits=10.0 required=5.0
 tests=FROM_NO_LOWER,HEAD_ILLEGAL_CHARS,HTML_70_80,
 HTML_MESSAGE,HTML_TAG_BALANCE_TABLE,INVALID_MSGID,
 MIME_BASE64_LATIN,MIME_BASE64_NO_NAME,MIME_BASE64_TEXT,
 SUBJ_ILLEGAL_CHARS
X-Spam-Flag: YES
X-Spam-Level: **********
Received: from iabr ([127.0.0.1])
 by iabr (Kerio MailServer 5.7.10)
 for tester at localhost.com;
 Tue, 14 Sep 2004 23:31:29 +0400
Date: Tue, 14 Sep 2004 23:31:29 +0300
Subject: **SPAM** Ñîîáùåíèå îò ïîñåòèòåëÿ ñàéòà
To: tester at localhost.com
Message-ID: <<0806be5899b459a859b085b60dbc9ac6 at domain.tld>>
From: =?iso-8859-1?B?8uXx8g==?= <òåñò>
Reply-To: =?iso-8859-1?B?8uXx8g==?= <òåñò>
X-Mailer: PHP mailer
X-Priority: 3
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="----------part_1_4147471150527"

This is a multi-part message in MIME format.

------------part_1_4147471150527
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: base64

TkFNRTogIPLl8fIKRU1BSUw6ICDy5fHyCkFERFJFU1M6ICDy5fHyCg==

------------part_1_4147471150527
Content-Type: text/html; charset=iso-8859-1
Content-Transfer-Encoding: base64

PHRhYmxlIGJvcmRlcj0wIGNlbGxwYWRkaW5nPTIgY2VsbHNwYWNpbmc9Mj4KPHRyPjx0ZCBiZ2Nv
bG9yPSIjZWVlZWVlIj48Zm9udCBmYWNlPSJWZXJkYW5hIiBzaXplPSIxIj48Yj5OQU1FPC9iPjwv
Zm9udD48L3RkPjx0ZCBiZ2NvbG9yPSIjZWVlZWVlIj48Zm9udCBmYWNlPSJWZXJkYW5hIiBzaXpl
PSIxIj7y5fHyJm5ic3A8L2ZvbnQ+PC90ZD48L3RyPgo8dHI+PHRkIGJnY29sb3I9IiNlZWVlZWUi
Pjxmb250IGZhY2U9IlZlcmRhbmEiIHNpemU9IjEiPjxiPkVNQUlMPC9iPjwvZm9udD48L3RkPjx0
ZCBiZ2NvbG9yPSIjZWVlZWVlIj48Zm9udCBmYWNlPSJWZXJkYW5hIiBzaXplPSIxIj7y5fHyJm5i
c3A8L2ZvbnQ+PC90ZD48L3RyPgo8dHI+PHRkIGJnY29sb3I9IiNlZWVlZWUiPjxmb250IGZhY2U9
IlZlcmRhbmEiIHNpemU9IjEiPjxiPkFERFJFU1M8L2I+PC9mb250PjwvdGQ+PHRkIGJnY29sb3I9
IiNlZWVlZWUiPjxmb250IGZhY2U9IlZlcmRhbmEiIHNpemU9IjEiPvLl8fImbmJzcDwvZ9udD48
L3RkPjwvdHI+CjwvdGFibGU+Cg==

------------part_1_4147471150527--




----- Original Message ----- 
From: "Martin T. Kutschker" <Martin.no5pam.Kutschker at blackbox.n0spam.net>
Newsgroups: typo3.dev
To: <typo3-dev at lists.netfielders.de>
Sent: Tuesday, September 14, 2004 11:32 AM
Subject: Re: [Typo3-dev] patches


> Jan-Erik Revsbech wrote:
>
> > You can send it to me, and I'll take a look at it. Also send me some
more
> > explananation of what the errors are, and please submit the bug
(possible
> > with your pathces attached) to bugs.typo3.org
>
> If you have some spare time have a look at my gsi_mailform_ext. The bug
> fixes for 3.5 or all in 3.6 now, but I have added some goodies that
> might be of general interest (templates, markers). Though I would
> rewrite some stuff for the Core.
>
> > ----- Original Message ----- 
> > From: "Ivan Abramov" <ivan at iwi.ru>
> > To: <typo3-dev at lists.netfielders.de>
> > Sent: Tuesday, September 14, 2004 1:34 AM
> > Subject: [Typo3-dev] patches
> >
> >>I made extension based on phpMailer (http://phpmailer.sourceforge.net ),
> >>that cover htmlmail & formmail problems, but there are another places in
> >>t3lib_div, nonextendable.
>
> I need some co-author to finish my work on a mail system wrapper. I have
> begun, but not finished a mail API that wraps around mail(), phpMailer
> and PEAR::Mail.
>
> And yes, Typo3 really needs to get rid of all the hardcoded mail() calls.
>
> Masi
> _______________________________________________
> Typo3-dev mailing list
> Typo3-dev at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev