[Typo3-dev] Problem with fe_adminLib and 3.6.0-RC2
Jan-Erik Revsbech
jer at moccompany.com
Tue Apr 27 22:24:42 CEST 2004
When using the fe_adminLib I have this small problem:
When using the setfixed I and use this line in my template (as the manual
says, and as the default template uses)
###THIS_URL######FORM_URL######SYS_SETFIXED_approve###
This will generate the url, but the problem is that from 3.5 to 3.6.0-RC1
the marker ###FORM_URL### is put through htmlspecialchars rendering my links
very bad in mails. Example:
http://www.administrationshuset.dk/vonhaller/index.php?id=23&type=1&cmd=edit&aC=b0e7286f&rU=4
(Notice how &type=1 is rendered as &type=1)
Now were at it, I propose to change the line to call typolink_URL instead of
a hardcoded link to index.php
I propose to change this line:
$this->markerArray['###FORM_URL###'] =
htmlspecialchars('index.php?id='.$GLOBALS['TSFE']->id.'&type='.$GLOBALS['TSF
E']->type.$this->nc.$this->conf['addParams']);
to this line:
$this->markerArray['###FORM_URL###'] =
$this->cObj->typolink_URL(array('parameter'=>$GLOBALS['TSFE']->id,'additiona
lParams'=>$this->ns.$this->conf['addParams'].'&type='.$GLOBALS['TSFE']->type
));
Can this be changed back before friday? I think I only have write access to
the t3lib in CVS, so I can not correct it myself at is resides in
tslib/media/
Actually I do have one other problem with the fe_adminLib but this is not
really a bug. The above lines will include the &type=1 in the links when i
use frames ( I hate frames myself, but the customer wants it.). This is OK
when the ###FORM_URL### is used in the template for output on the page, but
is is not good when it is used in email because the link will be a link to
the specific frame (with type=1) and not the top frameset (type=0 default).
I can see one way out, to create one additional maker calle
###FORM_URL_EMAIL### , or ###FORM_URL_NOTYPE### which can be included in
emails. This link should then not contain the type=XX parameter.
/Jan-Erik
More information about the TYPO3-dev
mailing list